HDDS-15677. Update client side version checks to use isSupportedBy.#10611
Open
errose28 wants to merge 6 commits into
Open
HDDS-15677. Update client side version checks to use isSupportedBy.#10611errose28 wants to merge 6 commits into
isSupportedBy.#10611errose28 wants to merge 6 commits into
Conversation
errose28
added
the
zdu
Contributor
Author
|
Compat test failure isn't related to this PR, despite the suite it occurred in:
|
ayushtkn
approved these changes
Jul 1, 2026
Contributor
Author
|
Build expired so rerunning just the failing jobs didn't work. Rerunning everything now. Thanks for the approval @ayushtkn . @dombizita would you like to check the last commit? |
ayushtkn
approved these changes
Jul 10, 2026
dombizita
approved these changes
Jul 13, 2026
* HDDS-14496-zdu: (417 commits) HDDS-15808. Replace json-simple with Jackson in httpfsgateway (apache#10710) HDDS-15753. Rename TestClock to MockClock (apache#10712) HDDS-14759. Local Empty file is written and retained even when key write fails (apache#10707) HDDS-15647. Bump Node.js to 24.17.0 (apache#10590) HDDS-15783. Handle empty lists in ScmListCodec deserialization (apache#10690) HDDS-15768. Bracket IPv6 literals in Ratis peer addresses (apache#10686) HDDS-15679. [Recon] Fix DN dropdown mismatch with pending deletion API (apache#10615). HDDS-15692. Enable GitHub Copilot code review when a pull request is opened (apache#10705) HDDS-15739. Fix ListObjectsV2 continuation-token: wrong XML element name and empty-token handling (apache#10668) HDDS-15648. Improve TestSnapshotDiffManager#testThreadPoolIsFull drain scenario (apache#10632) HDDS-15803. Fix parameter number warning in OMKeyRequest.allocateBlock. (apache#10701) HDDS-15480. Potential for NPE / infinite loop in StreamBlockReader (apache#10431) HDDS-15523. Speed up TestOMDbCheckpointServletInodeBasedXfer (apache#10680) HDDS-15788. Fix SST filtering BOOTSTRAP_LOCK contention introduced by RocksDB 10 upgrade (apache#10692) HDDS-15752. Rename base tests and helpers for naming convention in OM (apache#10672) HDDS-15754. Rename TestableCluster to MockCluster (apache#10691) HDDS-15755. Bump develocity-maven-extension to 2.5.0 (apache#10674) HDDS-14956. Add S3 HAProxy to ozonesecure-ha/test-haproxy-s3g.sh (apache#10685) HDDS-15762. Remove mini-chaos-tests (apache#10682) HDDS-14577. Handle missing metadata dir when updating container state (apache#10565). ... Conflicts: hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/rpc/TestRpcClient.java
Contributor
Author
|
Minor merge conflict in the test file resolved after the base branch was updated from master. Will merge this if CI comes back green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace client side version comparison that was previously using
compareTowith the new and more readableisSupportedBy. No functional change is expected.compareTocannot be removed since it is built into the enum, and it provides correct results so there is no harm other than readability.What is the link to the Apache JIRA
HDDS-15677
How was this patch tested?
New coverage was added for the client side version parsing which was previously missing. These tests were generated by Claude Code and reviewed by me.
Green run on my fork